Try to substitute tree for all uses of fetchTree instead of just in flakes #3520
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix the FIXME in fetchTree.cc:86
Wasn't quite sure how having a nar hash interacts with resolved refs. Since narHash is optional, a resolved ref could be immutable, but then possibly not locked? But then it doesn't make sense to assume that fetchOrSubstituteTree returns a lockedRef:
nix/src/libexpr/flake/flake.cc
Line 210 in 8c75621
Should that be treated as an immutable ref but not locked? Or should substitute only occur for locked refs?