Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installables refactor #3583

Merged
merged 3 commits into from
May 12, 2020
Merged

Installables refactor #3583

merged 3 commits into from
May 12, 2020

Commits on May 9, 2020

  1. InstallableExpr unused

    @mkenigs
    mkenigs committed May 9, 2020
    Configuration menu
    Copy the full SHA
    bf81dd4 View commit details
    Browse the repository at this point in the history

  2. Refactor installables 

    InstallableValue has children InstallableFlake and InstallableAttrPath, but InstallableFlake was overriding toDerivations, and usage was changed so that InstallableFlake didn't need cmd. So these changes were made:
InstallableValue::toDerivations() -> InstalllableAttrPath::toDerivations()
InstallableValue::cmd -> InstallableAttrPath::cmd

InstallableValue uses state instead of cmd

toBuildables() and toDerivations() were made abstract
    @mkenigs
    mkenigs committed May 9, 2020
    Configuration menu
    Copy the full SHA
    9f4cfbb View commit details
    Browse the repository at this point in the history

  3. Reorder to build 

    This reverts commit 883948d.
    @mkenigs
    mkenigs committed May 9, 2020
    Configuration menu
    Copy the full SHA
    73ee1af View commit details
    Browse the repository at this point in the history