nix profile: Support CA derivations #6197
Conversation
|
I see you moved the declarations to match the location of the definitions. But I must admit, I would prefer keeping ways to process installables separate from the definition of installables themselves. C.f. bcde545 when I wanted to define derivation. Less on principle, more for practical reasons, I have been thinking for #6182 maybe the churn of splitting |
| if (auto installable2 = std::dynamic_pointer_cast<InstallableFlake>(installable)) { | ||
| // FIXME: make build() return this? |
There was a problem hiding this comment.
I do think what buildPaths returns could help with this or updateStorePaths? Each BuiltPath contains the paths for the outputs requested, so you don't need to do another queryDerivationOutputMap if you can use it.
There was a problem hiding this comment.
No, the issue here is that we need the resolved flakeref / attrpath.
Fixes nix-daemon: src/libstore/sqlite.cc:97: nix::SQLiteStmt::Use::Use(nix::SQLiteStmt&): Assertion `stmt.stmt' failed. which happens because the daemon doesn't properly handle the case where ca-derivations isn't enabled at daemon startup.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-26/18252/1 |
Also moved some installable-related functions from
command.hhintoInstallableininstallables.hh.