Support systemd socket activation support more comprensively #7892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
requested review from
fricklerhandwerk and
edolstra
as code owners
|
Will need to fix macOS failure. |
Ericson2314
force-pushed
the
systemd-multi-socket
branch
from
f38006b
to
9aedd37
Compare
Ericson2314
force-pushed
the
systemd-multi-socket
branch
2 times, most recently
from
310266c
to
ab3a602
Compare
We now support: 1. Multiple sockets, per the systemd socket activation spec 2. The sockets not having pid/uid/gid peer info because they might not be Unix domain sockets. 3. `--stdio` on the new `nix daemon`, not just the old `nix-daemon`. In addition, `PeerInfo` is made more type safe with `std::optional`. These changes are by @edolstra, taken from NixOS#5265. This is just that PR *without* the TCP parts, which I gathered are the controversial parts. Hopefully this remainder is not so controversial.
Ericson2314
force-pushed
the
systemd-multi-socket
branch
from
ab3a602
to
864ff3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We now support:
Multiple sockets, per the systemd socket activation spec
The sockets not having pid/uid/gid peer info because they might not be Unix domain sockets.
Context
The changes are by @edolstra, taken from #5265. This is just that PR without the TCP parts, which I gathered are the controversial parts. Hopefully this remainder is not so controversial.
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*