string Value refactor #9047
Merged
string Value refactor #9047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
new-cli
edolstra
reviewed
Sep 26, 2023
Create context, string_view, and c_str, accessors throughout in order to better support improvements to the underlying string representation.
tomberek
force-pushed
the
tomberek.string_refactor
branch
from
c21417d
to
399ef84
Compare
roberth
approved these changes
Sep 28, 2023
jlesquembre
added a commit
to tweag/nix
that referenced
this pull request
Nov 28, 2023
Related to NixOS#9047
jlesquembre
added a commit
to tweag/nix
that referenced
this pull request
Dec 6, 2023
Related to NixOS#9047
jlesquembre
added a commit
to tweag/nix
that referenced
this pull request
Dec 14, 2023
Related to NixOS#9047
jlesquembre
added a commit
to tweag/nix
that referenced
this pull request
Jan 9, 2024
Related to NixOS#9047
jlesquembre
added a commit
to tweag/nix
that referenced
this pull request
Feb 24, 2024
Related to NixOS#9047
jlesquembre
added a commit
to tweag/nix
that referenced
this pull request
Mar 28, 2024
Related to NixOS#9047
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Factor out string Value getters in order to prepare for changes to the string representation.
Context
#9034
Priorities
Add 👍 to pull requests you find important.