libexpr: apply static analysis "quick fix" to splitted files #9089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thufschmitt
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Barring acceptance of #9059 (which is already discussed by others, so I won't interfere), this looks fine (and useful) to me 👍
|
@inclyc see how I editted the description to do the "depends on" thing so that blocker shows up in CI. |
This is an NFC PR that splits epilogue & prologue from parser. As mentioned in NixOS#8812, we can add static checking tools & auto formatting for these files, but if it is written .y directly, the clang parser cannot understand the code is actually "C++".
This PR contains no functioanl change, there are bunch of suggesstions by clang-tidy in the file and there are fixes available. Including: - 0 -> nullptr - use `auto` for iterator types - sort `#include`s - closing namespace comment - use `.empty()` instead of comparing it with empty object - use `auto` if it the type is apparently specified (e.g. `new Type`) - add const specifier or `&` to improve readability
inclyc
force-pushed
the
users/inclyc/split-yacc-2
branch
from
348f743
to
816e3cc
Compare
|
🎉 All dependencies have been resolved ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR contains no functioanl change, there are bunch of suggesstions
by clang-tidy in the file and there are fixes available.
Including:
autofor iterator types#includes.empty()instead of comparing it with empty objectautoif it the type is apparently specified (e.g.new Type)&to improve readabilityContext
This PR depends on #9059 , please do not review commits in that PR
depends on #9059
Priorities
Add 👍 to pull requests you find important.