-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Nixpkgs to fix static build #9518
Conversation
The problem was since switching to use libgit2, we had a package in our closure (`http-parser`) that was always trying to build as a shared object. Underlying Nixpkgs PR (a 23.05 backport) NixOS/nixpkgs#271202 Flake lock file updates: • Updated input 'nixpkgs': 'github:NixOS/nixpkgs/9ba29e2346bc542e9909d1021e8fd7d4b3f64db0' (2023-11-13) → 'github:NixOS/nixpkgs/36c4ac09e9bebcec1fa7b7539cddb0c9e837409c' (2023-11-30)
Blocked on Nixpkgs release staging process. See nixpk.gs tracker. |
@@ -1,7 +1,13 @@ | |||
{ | |||
description = "The purely functional package manager"; | |||
|
|||
inputs.nixpkgs.url = "github:NixOS/nixpkgs/nixos-23.05-small"; | |||
# TODO Go back to nixos-23.05-small once | |||
# https://github.com/NixOS/nixpkgs/pull/271202 is merged. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
@roberth I think it might be OK to not wait for that? While this a medium-mass-rebuild for Nixpkgs, it is not a mass rebuild for us. I am a bit more hasty because I would like to see Hydra at 100% before doing merging the |
This caused a bit of disruption Not sure how to weigh the trade-off in this particular case (which I expect is solved now), but let's keep avoiding any Nixpkgs staging dependencies. More concerning perhaps is the apparent lack of progress on |
Update Nixpkgs to fix static build (cherry picked from commit 9817788) Change-Id: Ibe07a263f4d8f3b230775fb993881e5151a53784
Motivation
Fixes #9496
Context
The problem was since switching to use libgit2, we had a package in our closure (
http-parser
) that was always trying to build as a shared object.Underlying Nixpkgs PR (a 23.05 backport) NixOS/nixpkgs#271202
Priorities
Add 👍 to pull requests you find important.