Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nixpkgs to fix static build #9518

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Update Nixpkgs to fix static build #9518

merged 1 commit into from
Dec 6, 2023

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Dec 1, 2023

Motivation

Fixes #9496

Context

The problem was since switching to use libgit2, we had a package in our closure (http-parser) that was always trying to build as a shared object.

Underlying Nixpkgs PR (a 23.05 backport) NixOS/nixpkgs#271202

Priorities

Add 👍 to pull requests you find important.

The problem was since switching to use libgit2, we had a package in our
closure (`http-parser`) that was always trying to build as a shared
object.

Underlying Nixpkgs PR (a 23.05 backport)
NixOS/nixpkgs#271202

Flake lock file updates:

• Updated input 'nixpkgs':
    'github:NixOS/nixpkgs/9ba29e2346bc542e9909d1021e8fd7d4b3f64db0' (2023-11-13)
  → 'github:NixOS/nixpkgs/36c4ac09e9bebcec1fa7b7539cddb0c9e837409c' (2023-11-30)
@Ericson2314 Ericson2314 changed the title flake.lock: Update Nixpkgs to fix static build Update Nixpkgs to fix static build Dec 1, 2023
@roberth
Copy link
Member

roberth commented Dec 4, 2023

Blocked on Nixpkgs release staging process. See nixpk.gs tracker.

@@ -1,7 +1,13 @@
{
description = "The purely functional package manager";

inputs.nixpkgs.url = "github:NixOS/nixpkgs/nixos-23.05-small";
# TODO Go back to nixos-23.05-small once
# https://github.com/NixOS/nixpkgs/pull/271202 is merged.

This comment was marked as duplicate.

This comment was marked as duplicate.

@Ericson2314
Copy link
Member Author

@roberth I think it might be OK to not wait for that? While this a medium-mass-rebuild for Nixpkgs, it is not a mass rebuild for us.

I am a bit more hasty because I would like to see Hydra at 100% before doing merging the package.nix PR.

@edolstra edolstra merged commit 9817788 into master Dec 6, 2023
18 checks passed
@edolstra edolstra deleted the fix-static-build branch December 6, 2023 17:02
@roberth
Copy link
Member

roberth commented Dec 18, 2023

This caused a bit of disruption

Not sure how to weigh the trade-off in this particular case (which I expect is solved now), but let's keep avoiding any Nixpkgs staging dependencies.

More concerning perhaps is the apparent lack of progress on staging-next-23.11: https://hydra.nixos.org/jobset/nixpkgs/staging-next-23.05#tabs-evaluations

tebowy pushed a commit to tebowy/nix that referenced this pull request Jul 11, 2024
Update Nixpkgs to fix static build

(cherry picked from commit 9817788)
Change-Id: Ibe07a263f4d8f3b230775fb993881e5151a53784
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Fix static Nix build
3 participants