worker protocol: serialise cgroup stats in BuildResult
#9598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @r-vdp. Would you mind splitting this in two? I am not sure we want to be chaining the old legacy ssh protocol much, but we definitely want to add this to the worker protocol. |
Ericson2314
reviewed
Dec 12, 2023
Ericson2314
reviewed
Dec 12, 2023
r-vdp
force-pushed
the
serialise_cgroup_stats
branch
from
a625182
to
03af26c
Compare
r-vdp
force-pushed
the
serialise_cgroup_stats
branch
2 times, most recently
from
24e2e9a
to
6beae33
Compare
|
OK looking good! I think we just need a release note |
Ericson2314
reviewed
Dec 12, 2023
Ericson2314
reviewed
Dec 12, 2023
r-vdp
force-pushed
the
serialise_cgroup_stats
branch
from
6beae33
to
1990f4c
Compare
By doing so, they also get reported when building through the daemon.
r-vdp
force-pushed
the
serialise_cgroup_stats
branch
from
1990f4c
to
fe991a7
Compare
Ericson2314
reviewed
Dec 13, 2023
Ericson2314
changed the title
BuildResult
Ericson2314
approved these changes
Dec 13, 2023
Ericson2314
changed the title
BuildResultBuildResult
fricklerhandwerk
added
the
protocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
By doing so, they get reported when building through the daemon via either
unix://orssh-ng://.Priorities
Add 👍 to pull requests you find important.