More makefile preparations for Windows #9742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mindavi
approved these changes
Jan 11, 2024
Makefile
Outdated
| ifdef HOST_WINDOWS | ||
| # Windows DLLs are stricter about symbol visibilty than Unix shared | ||
| # objects --- see https://gcc.gnu.org/wiki/Visibility for details. | ||
| # This is a temporary sledghammer to export everything like on Unix, |
There was a problem hiding this comment.
Yeah, adding exports for all symbols will probably be a bit of work
There was a problem hiding this comment.
Same. It's not an urgent todo.
roberth
changed the title
These bits are not Cygwin-specific.
This is not the most elegant, but will match the SOs in exporting everything for now. Later we can refine what is public/private to clean up the interface.
Ericson2314
force-pushed
the
mingw-makefiles
branch
from
bd52ff2
to
90fdbfc
Compare
Ericson2314
added
build-problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See each commit for details. In the last one I tried to add some general comments to our entry-point
Makefileis easier to understand.Context
Preparing for #8901.
Picking up where #9736 left off
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.
CC @wegank @Mindavi