Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Windows paths in canonPath and absPath #9767

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Support Windows paths in canonPath and absPath #9767

merged 2 commits into from
Feb 27, 2024

Commits on Feb 16, 2024

  1. Factor out the Unix-specific parts of canonPathInner 

    This prepares the code to also support Windows paths in the next commit.
    @Ericson2314
    Ericson2314 committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    4531585 View commit details
    Browse the repository at this point in the history

  2. Support Windows paths in canonPath and absPath 

    `canonPath` and `absPath` work on native paths, and so should switch
between supporting Unix paths and Windows paths accordingly.

The templating is because `CanonPath`, which shares the implementation,
should always be Unix style. It is the pure "nix-native" path type for
virtual file operations --- it is part of Nix's "business logic", and
should not vary with the host OS accordingly.
    @Ericson2314
    Ericson2314 committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    319ec6f View commit details
    Browse the repository at this point in the history