-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert --log-format
to a setting
#9923
base: master
Are you sure you want to change the base?
Conversation
`BaseSetting` is never used on its own, so it's fairly trivial to remove.
`fun` has a default value, so we no longer need to be able to convert `SettingHandler` to `bool`.
ed27bc1
to
edf5eb1
Compare
Note: This PR was intended to demonstrate the setting handler functionality added in #9922. That PR is more controversial than I anticipated, so I've refactored this PR to not depend on it. I do believe #9922 is worthwhile and it does make the implementation of the EDIT: Aaaactually I take that back. The |
edf5eb1
to
2df1524
Compare
2df1524
to
9e100ec
Compare
9e100ec
to
4c35ede
Compare
Motivation
This closes #5561 by adding a
log-format
setting and avoids the issues of #8323 (namely, thatnix
andnix-build
have different default log formats) by adding alog-format-legacy
setting to override thelog-format
setting only for old-style commands likenix-build
.Priorities
Add 👍 to pull requests you find important.