Deprecate recursive mode #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
infinisil
force-pushed
the
deprecate-passing-directories
branch
3 times, most recently
from
d3df458
to
423417a
Compare
The recursive mode has caused problems because it doesn't do any filtering, which can mess with files in `.git` directories and elsewhere. While we could support sane implicit filters and an interface to filter explicitly, that adds complexity and maintenance burden. Instead, we can promote the use of `treefmt` instead, a "formatting multiplexer", which supports file filtering by default. So `nixfmt` will only be the "backend" formatter, while `treefmt` is the frontend. Previously discussed in a team meeting here: #151 (comment)
infinisil
force-pushed
the
deprecate-passing-directories
branch
from
423417a
to
ba0c3fa
Compare
This wasn't implemented anymore, and we've also decided to focus on using treefmt instead, which supports parallel formatting
|
While already touching this code, I cleaned up some unneeded code that was needed for parallelism in the past. That's not implemented anymore though, and treefmt can be used for parallelism instead. |
Closed
0x4A6F
approved these changes
Sep 3, 2024
piegamesde
approved these changes
Sep 3, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/formatting-team-meeting-2024-09-03/51584/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recursive mode has caused problems because it doesn't do any filtering, which can mess with files in
.gitdirectories and elsewhere. While we could support sane implicit filters and an interface to filter explicitly, that adds complexity and maintenance burden.Instead, we can promote the use of
treefmtinstead, a "formatting multiplexer", which supports file filtering by default. Sonixfmtwill only be the "backend" formatter, whiletreefmtis the frontend.Previously discussed in a team meeting here:
#151 (comment)