Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'pytorchWithCuda' missing, when 'pytorchWithoutCuda' exists #226

Closed
cstich opened this issue Nov 16, 2020 · 4 comments · Fixed by #288
Closed

'pytorchWithCuda' missing, when 'pytorchWithoutCuda' exists #226

cstich opened this issue Nov 16, 2020 · 4 comments · Fixed by #288
Labels
bug Something isn't working topic: search query

Comments

@cstich
Copy link

cstich commented Nov 16, 2020

So confusingly pytorchWithoutCuda exists as a searchable package whereas pytorchWithCuda does not. The defintion of both of them is just

pytorchWithCuda = self.pytorch.override { cudaSupport = true; };

pytorchWithoutCuda = self.pytorch.override { cudaSupport = false; };

so I am not sure why one is searchable and not the other.

@garbas garbas added the bug Something isn't working label Nov 17, 2020
@garbas
Copy link
Member

garbas commented Nov 17, 2020

@cstich thank you for reporting this. At the first glance I'm also not sure myself why this is the case. But maybe this means we are also not showing some other packages.

@jonringer
Copy link
Contributor

pytorchWithCuda would be marked unfree. I'm assuming we are only exposing "free" packages

@cstich
Copy link
Author

cstich commented Nov 17, 2020

@jonringer That would make sense, but what about packages such as steam and pytorch-bin. Aren't those also unfree software?

@jonringer
Copy link
Contributor

jonringer commented Nov 19, 2020

yes, but steam is "unfree redistributable". but pytorch is unfree, so I'm not sure.

I actually don't have a clue. pytorch and pytorchWithoutCuda are even aliases

garbas added a commit that referenced this issue Feb 7, 2021
* Reduce the numbers of bucket results on each ChangeBucket event
* Warmup after reindexing, fixes #250
* Using multiple sort keys, fixes #218
* Index also unfree packages, fixes #226, fixes #237
* Add wilcard query, fixes #279
garbas added a commit that referenced this issue Feb 7, 2021
* Reduce the numbers of bucket results on each ChangeBucket event
* Warmup after reindexing, fixes #250
* Using multiple sort keys, fixes #218
* Index also unfree packages, fixes #226, fixes #237
* Add wilcard query, fixes #279
garbas added a commit that referenced this issue Feb 7, 2021
* Reduce the numbers of bucket results on each ChangeBucket event
* Warmup after reindexing, fixes #250
* Using multiple sort keys, fixes #218
* Index also unfree packages, fixes #226, fixes #237
* Add wilcard query, fixes #279
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working topic: search query
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants