-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos testing for NetworkManager #71151
Comments
Agreed. While developing tests for the multipath TCP module #59342 I was surprised to see no networkmanager module. |
Thank you for your contributions.
|
Bleh. |
I marked this as stale due to inactivity. → More info |
consequences of our inactions #283717 |
Fixes NixOS#283717 It brings me *zero bloody pleasure* to say that we apparently didn't have any tests for networkmanager of all things! NixOS#71151
Describe the bug
NetworkManager is a particularly important component and we don't have any tests for it that could block a channel advance.
In particular, a change can happen on nixos-unstable leaving users without functioning networking, and while rollbacks are possible it isn't an excuse to allow that to reach production systems. NixOS doesn't produce a failsafe generation either.
Manual testing is also cumbersome if we want to make a new stable release.
Upstream NetworkManager does have some integration testing
but obviously not useful to us.
I think to start, if we at least had a test that verifies the services start without issues would be great.
The text was updated successfully, but these errors were encountered: