Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos testing for NetworkManager #71151

Closed
worldofpeace opened this issue Oct 14, 2019 · 5 comments · Fixed by #292472
Closed

nixos testing for NetworkManager #71151

worldofpeace opened this issue Oct 14, 2019 · 5 comments · Fixed by #292472
Labels
6.topic: nixos 6.topic: testing Tooling for automated testing of packages and modules

Comments

@worldofpeace
Copy link
Contributor

Describe the bug
NetworkManager is a particularly important component and we don't have any tests for it that could block a channel advance.

In particular, a change can happen on nixos-unstable leaving users without functioning networking, and while rollbacks are possible it isn't an excuse to allow that to reach production systems. NixOS doesn't produce a failsafe generation either.

Manual testing is also cumbersome if we want to make a new stable release.

Upstream NetworkManager does have some integration testing

but obviously not useful to us.

I think to start, if we at least had a test that verifies the services start without issues would be great.

@worldofpeace worldofpeace added 0.kind: bug 6.topic: nixos 6.topic: testing Tooling for automated testing of packages and modules and removed 0.kind: bug labels Oct 14, 2019
@teto
Copy link
Member

teto commented Oct 15, 2019

Agreed. While developing tests for the multipath TCP module #59342 I was surprised to see no networkmanager module.
I had some difficulties with the nixos test infrastructure at first because the test infra will by default install a slirp interface (config.virtualisation.qemu.networkingOptions) and it messed up the interface naming. Like I would clear config.virtualisation.qemu.networkingOptions but interfaces would still be named starting from eth1 instead of eth0.
Just thought I would mention it in case the brave soul writing the test is interested in multihoming.
(but that's more a concern I have with the test infra).

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@jtojnar
Copy link
Member

jtojnar commented Jun 1, 2020

Bleh.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@stale
Copy link

stale bot commented Nov 28, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 28, 2020
@lf-
Copy link
Member

lf- commented Jan 25, 2024

consequences of our inactions #283717

@lf- lf- removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 25, 2024
lf- added a commit to lf-/nixpkgs that referenced this issue Jan 25, 2024
Fixes NixOS#283717

It brings me *zero bloody pleasure* to say that we apparently
didn't have any tests for networkmanager of all things!
NixOS#71151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos 6.topic: testing Tooling for automated testing of packages and modules
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants