-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
darwin: introduce darwinArch, apply in {cc,bintools}-wrappers #114817
Conversation
These are now provided by the standard bintools and cc wrappers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Looks like it broke stdenv on
|
I was so sure it had been tested as part of the |
@thefloweringash looks like thefloweringash@178ad9a indeed fixes the issue. |
Excellent! Thank you for testing. I've opened this as #114944. |
This broke |
Workaround for build failure after adding mandatory -arch argument. Nixpkgs targets a single architecture, so this saves a small amount of wasted build effort. See NixOS#114817 (comment)
Motivation for this change
Extracted out of #105026. This, as well as #111988, try to make the darwin {cc,bintools}-wrappers use the correct flags for the target platform. A version of these flags previously existed only in the xcode wrapper.
Tested only as part of #105026. It changes the compiler and linker flags for all darwin packages, so there's a potential for a lot of breakage.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)