-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bitwarden_rs: remove failing integration test #118072
Conversation
This test is hitting a timeout because it's trying to build firefox-unwrapped. The idea is good, test that the web service works with different database backends, but building firefox is way too big a task for a small service like this. Here's the logs from one of the failing tests: https://hydra.nixos.org/build/140338120 From the looks of it, the only other test to use firefox-unwrapped and selenium in the same way is nginx-etag, which also times out: https://hydra.nixos.org/build/140337879 If there is no alternative way of automating the integration tests, I therefore propose that we delete them. Right now, the only purpose they serve is to block newer releases on unstable.
@SuperSandro2000 I think I figured out why the bitwarden_rs tests were failing. |
Maybe firefox-unwrapped was not cached? |
I feel very strongly that this is the wrong way to tackle this issue. The test isn't even part of the tested set, so I don't see how it could block anything. Firefox should mostly come from the cache: https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.firefox-unwrapped.x86_64-linux/all The bitwarden tests fail regardless. https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.bitwarden.sqlite.x86_64-linux/all |
Ah, it actually seems like the x86_64 tests are now passing! However, aarch64 is still failing. Maybe the problem is that firefox is not cached for aarch64? https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.firefox-unwrapped.aarch64-linux/all |
I'm not sure what you mean by this? |
The list of tests that decide whether a channel bump can occur. nixpkgs/nixos/release-combined.nix Lines 36 to 158 in 2446625
|
Interesting, I didn't know about that. Then why is bitwarden_rs still in version v1.17.0 on unstable? |
Search must be outdated. https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.bitwarden_rs.x86_64-linux |
Thanks mweinelt, I agree there is no issue here. The test is not "building firefox", it depends on firefox, like it depends on linux and systemd. |
Thank you all for helping out ❤️ |
This test is hitting a timeout because it's trying to build
firefox-unwrapped. The idea is good, test that the web service works with
different database backends, but building firefox is way too big a task for a
small service like this.
Here's the logs from one of the failing tests:
https://hydra.nixos.org/build/140338120
From the looks of it, the only other test to use firefox-unwrapped and selenium
in the same way is nginx-etag, which also times out:
https://hydra.nixos.org/build/140337879
If there is no alternative way of automating the integration tests, I therefore
propose that we delete them. Right now, the only purpose they serve is to block
newer releases on unstable.
If you want me to, I can also create a PR to remove the failing nginx-etag test.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)