-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc/meta.xml: don't encourage users to add a meta.version attribute #12156
doc/meta.xml: don't encourage users to add a meta.version attribute #12156
Conversation
By analyzing the blame information on this pull request, we identified @7c6f434c, @edolstra and @domenkozar to be potential reviewers |
👍 |
Well, if we slowly replace string parsing with separate explicit specification, at some point we will get rid of the sad stories like the recent |
+1 for making +1 for this PR as a step to move this way (many derivations already pass |
…m-manual doc/meta.xml: don't encourage users to add a meta.version attribute
Isn't it a step towards not passing version except as a part of |
If |
And this PR specifically remove an instance of passing the version in favour of parsing. |
Is there an issue, Wiki page, mailing list posting, or some other document that explains what exactly we'd gain by having |
We're currently extracting version from |
What's the argument for smashing Of course the current duplication is non-ideal, but this PR doesn't do anything to improve the situation. |
@nckx, if you want to improve the situation, please don't hesitate to submit a PR that does! |
@peti: That makes little sense if the attribute is being deprecated. |
@nckx: I think they meant to have drv.version instead of drv.meta.version. |
@bjornfor : I see that the commit removed Leaving no |
I know one use case for parsing it – getting name and version just from a path, e.g. |
My two cents: |
That attribute is completely redundant since it just duplicates information from "name".
Cc: @7c6f434c who added that section in e39b1f4.