treewide: Do a number of no-op cleanups for cross and darwin #121654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
requested review from
matthewbauer,
thefloweringash and
sternenseemann
Ericson2314
commented
May 4, 2021
|
Result of 1 package marked as broken and skipped:
4 packages built successfully:
Result of 1 package built successfully:
|
Ericson2314
force-pushed
the
darwin-cross-prep
branch
from
4fcbfa9
to
8d96357
Compare
Ericson2314
requested review from
edolstra,
FRidh,
infinisil and
nbp
as code owners
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
and removed
10.rebuild-darwin: 101-500
labels
I am taking the non-invasive parts of NixOS#110914 to hopefully help out with NixOS#111988. In particular: - Use `lib.makeScopeWithSplicing` to make the `darwin` package set have a proper `callPackage`. - Adjust Darwin `stdenv`'s overlays keeping things from the previous stage to not stick around too much. - Expose `binutilsNoLibc` / `darwin.binutilsNoLibc` to hopefully get us closer to a unified LLVM and GCC bootstrap.
Ericson2314
force-pushed
the
darwin-cross-prep
branch
from
8d96357
to
470640e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I am taking the non-invasive parts of #110914 to hopefully help out with #105026.
In particular:
Use
lib.makeScopeWithSplicingto make thedarwinpackage set havea proper
callPackage.Adjust Darwin
stdenv's overlays keeping things from the previousstage to not stick around too much.
Expose
binutilsNoLibc/darwin.binutilsNoLibcto hopefully get uscloser to a unified LLVM and GCC bootstrap.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)