Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make backport bot link to criteria, make CONTRIBUTING.md more prominent #128163

Merged
merged 2 commits into from
Jun 26, 2021

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Jun 26, 2021

Motivation for this change

Discussion on NixOS dev chat that:

  • Automation tools should instruct their users clearly what tasks are still on the user, linking to the rules instead of requiring that users know their location by heart.
  • The CONTRIBUTING.md file should not be hidden in .github.
Things done
  • Somebody needs to figure out how to check that the updated bot config is valid syntax (if that is possible pre-merge).

CC from the discussion: @alyssais @lovesegfault @Ma27 @risicle @ryantm @samueldr @SuperSandro2000

nh2 added 2 commits June 26, 2021 04:51
Automation tools should instruct their users clearly what tasks are still on the user.

Updates the bot's version to get the `pull_description` feature:
korthout/backport-action#64
@nh2
Copy link
Contributor Author

nh2 commented Jun 26, 2021

I also requested a feature from the bot authors that will make this even better: korthout/backport-action#75

Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. No experience with the backport action though, so @domenkozar should probably look too.

@domenkozar domenkozar merged commit 6556d64 into NixOS:master Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants