obb: switch to fetchFromGitHub and passthru.tests

[willcohen]

Motivation for this change

Followup to #153496 discussion.

Now uses fetchFromGitHub instead of fetchurl.

Also, per package docs, the reason to prefer package tests over the install check, in this case, is because the test is being introduced in nixpkgs itself and this encourages speedier builds (acknowledging in this case that the speed difference is trivial, but I don't mind trying to use current best practices on a new package).

@thiagokokada @legendofmiracles

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[thiagokokada]

I am still not convinced that using a clear hack just to make tests pass is better than using installCheckPhase in this case, however since it is in docs I think it is fair.

[willcohen]

Also @legendofmiracles the reason for removing the version check is just that it's literally not implemented yet in v0.0.1 -- I lifted it from the babashka derivation originally, where it does work.

[willcohen]

Result of nixpkgs-review pr 153601 run on x86_64-darwin 1

1 package built:

• obb

[legendofmiracles]

Also @legendofmiracles the reason for removing the version check is just that it's literally not implemented yet in v0.0.1 -- I lifted it from the babashka derivation originally, where it does work.

Oh, thanks for clarifying. That was indeed a misunderstanding 😅

@thiagokokada I agree, it's a clear design flaw. Maybe one that can somehow be fixed...
But current best practices want otherwise, and many other packages also do the same hack.