os-release: preserve fields from being excessively quoted

[cab404]

Description of changes

Recent change made ID=nixos checks, used by many programs to patch static nixos binaries and other reasons, obsolete.
This removes ID and ID_LIKE fields from being quoted — as quoting those violates should never be necessary according to os-release file format

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[cab404]

I can also add lowercase, whitespace and other checks, just in case :D

[cab404]

With this patch, ID field is generated correctly

BUG_REPORT_URL="https://github.com/NixOS/nixpkgs/issues"
BUILD_ID="22.05.20220314.dirty"
DOCUMENTATION_URL="https://nixos.org/learn.html"
HOME_URL="https://nixos.org/"
ID=nixos
LOGO="nix-snowflake"
NAME="NixOS"
PRETTY_NAME="NixOS 22.05 (Quokka)"
SUPPORT_URL="https://nixos.org/community.html"
VERSION="22.05 (Quokka)"
VERSION_CODENAME="quokka"
VERSION_ID="22.05"

[peterhoeg]

This breaks a lot of existing checks for nixos, as it replaces ID=nixos with ID="nixos".

If checks are broken, they should be fixed as there is nothing wrong with having the fields without spaces quoted as you correctly point out: Assignments that do not include these special characters may be enclosed in quotes too, but this is optional. Having a hardcoded list of fields seems like a suboptimal way to solve it, so in order of preference: 1. fix the places that break because they assume a literal ID=nixos (just out curiosity what exactly breaks?) 2. if the value contains characters outside A–Z, a–z, 0–9, quote it - otherwise don't. And this should be regardless of the field. A hardcoded workaround for 2 specific fields is not the way to go so NAK on this specific solution.

[cab404]

This breaks a lot of existing checks for nixos, as it replaces ID=nixos with ID="nixos".
If checks are broken, they should be fixed as there is nothing wrong with having the fields without spaces quoted as you correctly point out: Assignments that do not include these special characters may be enclosed in quotes too, but this is optional. Having a hardcoded list of fields seems like a suboptimal way to solve it, so in order of preference: 1. fix the places that break because they assume a literal ID=nixos (just out curiosity what exactly breaks?) 2. if the value contains characters outside A–Z, a–z, 0–9, quote it - otherwise don't. And this should be regardless of the field. A hardcoded workaround for 2 specific fields is not the way to go so NAK on this specific solution.

E.g rust-analyzer’s vscode extension (I patched it), Airshipper, probably many more unexpected scripts.
I think that introducing this may break too much many things, and that is generally unnecessary anyway, so 2 lgtm. I see the solution with hardcoding 2 fields as valid as those two fields have different constraints in /etc/os-release documentation.

[peterhoeg]

I'd still argue that these downstream consumers are broken, but to avoid pissing off too many people, please change this to look for non-alphanummeric in the values and then write them out un-quoted in that case.

[cab404]

@peterhoeg please, re-review

[peterhoeg]

Thank you all!