MongoDB service: switch configuration format to YAML #18574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ericsagnes, thanks for your PR! By analyzing the annotation information on this pull request, we identified @offlinehacker, @peti and @bluescreen303 to be potential reviewers |
|
The only packages for which I needed mongodb 2.x were unifi and mfi, and since those provide their own config files when invoking mongodb, these changes shouldn't break anything. |
|
@elitak Thanks for the feedback! |
7 tasks
globin
approved these changes
Sep 15, 2016
|
Should this include a release note which says the |
Configuration format has changed from MongoDB 2.6 to YAML and MongoDB 2.4 is EOL since March 2016.
ericsagnes
force-pushed
the
feat/mongodb
branch
from
7be1098
to
9132088
Compare
|
@rvl Good catch, I updated the PR with release notes. |
domenkozar
reviewed
Sep 19, 2016
| @@ -12,13 +12,11 @@ let | |||
|
|
|||
| mongoCnf = pkgs.writeText "mongodb.conf" | |||
There was a problem hiding this comment.
Upstream documentation uses .conf files.
Do you think we should change to .yaml anyway?
|
Hmm, no. Let's keep the upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Configuration format has changed from MongoDB 2.6 to YAML and MongoDB 2.4 is EOL since March 2016.
The YAML format is the default format and 2.4 configuration file format is meant only for backwards compatibility.
It make sense to have YAML file as default as it is how users would expect to configure MongoDB if they read the upstream documentation.
This will likely break the mongodb service if the used package is
mongodb248, but as 2.4 is EOL and YAML format is the default and provides more configuration options there is a trade-off to chose.cc @elitak as he resurrected 2.4.8
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)