Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310Packages.mistune: 0.8.4 -> 2.0.4 #186272

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

dotlambda
Copy link
Member

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@@ -38,7 +38,7 @@ buildPythonPackage rec {
homepage = "https://github.com/miyakogi/m2r";
description = "Markdown to reStructuredText converter";
license = licenses.mit;
maintainers = with maintainers; [ SuperSandro2000 ];
maintainers = with maintainers; [ AndersonTorres SuperSandro2000 ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What am I doing here??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were a maintainer of the removed pkgs/tools/text/m2r.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndersonTorres Do you want me to remove your name?

jonasnick added a commit to jonasnick/nix-bitcoin that referenced this pull request Aug 14, 2022
@dotlambda dotlambda merged commit eb642f8 into NixOS:master Aug 15, 2022
@dotlambda dotlambda deleted the mistune-single-version branch August 15, 2022 06:53
@smancill
Copy link
Contributor

smancill commented Aug 15, 2022

Looks like this broke python3Packages.nbconvert (and thus, python3Packages.jupyter):

python3.10-nbconvert> ERROR: Could not find a version that satisfies the requirement mistune<2,>=0.8.1 (from nbconvert) (from versions: none)
python3.10-nbconvert> ERROR: No matching distribution found for mistune<2,>=0.8.1

smancill added a commit to smancill/nixpkgs that referenced this pull request Aug 17, 2022
@vcunat
Copy link
Member

vcunat commented Aug 19, 2022

Did you have any plans for 22.05?

@risicle
Copy link
Contributor

risicle commented Aug 19, 2022

Completely forgot about that :/

@dotlambda
Copy link
Member Author

It's only a small number of packages that are marked insecure on 22.05, I don't think we need to take action unless issues are opened. We can use mistune_2_0 where possible though.

@smancill
Copy link
Contributor

jupyter is broken on 22.05:

https://discourse.nixos.org/t/jupyter-broken-in-22-05/21108/1

github-actions bot pushed a commit that referenced this pull request Aug 20, 2022
mistune 0.8 was removed by #186272.

(cherry picked from commit 8d05ef5)
Ma27 pushed a commit to mayflower/nixpkgs that referenced this pull request Aug 22, 2022
mistune 0.8 was removed by NixOS#186272.

(cherry picked from commit 8d05ef5)
Ma27 pushed a commit to mayflower/nixpkgs that referenced this pull request Aug 22, 2022
mistune 0.8 was removed by NixOS#186272.

(cherry picked from commit 8d05ef5)
(cherry picked from commit 898d644)
jsoo1 pushed a commit to awakesecurity/nixpkgs that referenced this pull request Aug 8, 2023
jsoo1 pushed a commit to awakesecurity/nixpkgs that referenced this pull request Sep 7, 2023
awake-bot pushed a commit to awakesecurity/nixpkgs that referenced this pull request Oct 20, 2023
jsoo1 pushed a commit to awakesecurity/nixpkgs that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants