[staging-next] perlPackages.IOAsyncSSL: fix test #189116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply patch from Debian to fix test compatibility with OpenSSL 3
Comment on lines
+12007
to
+12009
| (fetchpatch { | ||
| # Fixes test compatibility with OpenSSL 3 | ||
| url = "https://sources.debian.org/data/main/libi/libio-async-ssl-perl/0.23-1/debian/patches/upgrade-error-match.patch"; |
There was a problem hiding this comment.
Suggested change
| (fetchpatch { | |
| # Fixes test compatibility with OpenSSL 3 | |
| url = "https://sources.debian.org/data/main/libi/libio-async-ssl-perl/0.23-1/debian/patches/upgrade-error-match.patch"; | |
| # Fixes test compatibility with OpenSSL 3 | |
| (fetchpatch { | |
| url = "https://sources.debian.org/data/main/libi/libio-async-ssl-perl/0.23-1/debian/patches/upgrade-error-match.patch"; |
thats only really important for CVE comments I think
There was a problem hiding this comment.
The purpose of the patch is not clear from the name, i think it's useful to have this as a comment. Also, keeping the comment over the specific fetchpatch makes more sense to me and is consistent with perlPackages in general, imho.
There was a problem hiding this comment.
I meant that I think for the CVE detection to the work the comment must be before the fetchpatch, not somewhere in the middle.
SuperSandro2000
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply patch from Debian to fix test compatibility with OpenSSL 3
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes