python310Packages.flask-wtf: fix failing build #190680
Conversation
|
Pull request opened on the Flask WTF repository: pallets-eco/flask-wtf#533 |
|
@ofborg build calibre-web |
|
Result of 3 packages marked as broken and skipped:
5 packages failed to build:
10 packages built:
|
|
@ofborg build pgadmin4 python310Packages.flask-admin python310Packages.ihatemoney apache-airflow python310Packages.apache-airflow |
|
pgadmin build will be fixed with #188575 6.13 requires Werkzeug 2.1 |
|
Arguably you could just pull your fix as a patch, we may forget to ever remove the test disablement. |
| @@ -32,10 +32,14 @@ buildPythonPackage rec { | |||
| pytestCheckHook | |||
| ]; | |||
|
|
|||
| disabledTests = [ | |||
| "test_set_default_message_language" | |||
There was a problem hiding this comment.
Please add a comment why this test is disabled
There was a problem hiding this comment.
Arguably you could just pull your fix as a patch, we may forget to ever remove the test disablement.
Thanks for the review.
I removed this disabled test and use the fix as a patch in the package.
anthonyroussel
force-pushed
the
fix-flask-wtf
branch
from
0d05cb3
to
7083952
Compare
Description of changes
Fix failing build of flask-wtf
Added myself to maintainers
Fixes the flask-wtf failing build on the staging-next PR/branch: #188284
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes