Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hex: init at 0.4.2 #190813

Merged
merged 1 commit into from
Sep 12, 2022
Merged

hex: init at 0.4.2 #190813

merged 1 commit into from
Sep 12, 2022

Conversation

IvarWithoutBones
Copy link
Member

@IvarWithoutBones IvarWithoutBones commented Sep 11, 2022

Description of changes

This adds hex, an futuristic take on hexdump, made in Rust.

Fixes #190768

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Copy link
Member

@newAM newAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed points
  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64-linux
  • executables tested on x86_64-linux
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.platforms is set
  • meta.maintainers is set
  • build time only dependencies are declared in nativeBuildInputs
  • source is fetched using the appropriate function
  • the list of phases is not overridden
  • when a phase (like installPhase) is overridden it starts with runHook preInstall and ends with runHook postInstall.
  • patches that are remotely available are fetched with fetchpatch

pkgs/tools/misc/hex/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/hex/default.nix Outdated Show resolved Hide resolved
@azahi
Copy link
Member

azahi commented Sep 11, 2022

Result of nixpkgs-review pr 190813 run on x86_64-linux 1

1 package built:
  • hex

@onny
Copy link
Contributor

onny commented Sep 12, 2022

Result of nixpkgs-review pr 190813 run on x86_64-linux 1

1 package built:
  • hex

@onny onny merged commit 6a8d5a6 into NixOS:master Sep 12, 2022
@onny
Copy link
Contributor

onny commented Sep 12, 2022

Thank you!

@IvarWithoutBones IvarWithoutBones deleted the init-hex branch September 12, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packaging request: hex
6 participants