ubuntu-font-family: use mkDerivation #193943
Conversation
| ''; | ||
|
|
||
| sha256 = "090y665h4kf2bi623532l6wiwkwnpd0xds0jr7560xwfwys1hiqh"; | ||
| outputHashMode = "recursive"; | ||
| outputHash = "sha256-EEcYtOeOd2DKyRLo1kG7lk8euaFilCFMXMJNAosxHiQ="; |
There was a problem hiding this comment.
why is this a fixed output derivation?
There was a problem hiding this comment.
From what I understand, the output only depends on the current version used, so it would make sense to use a fixed-output derivation. Are you seeing something that would make this derivation variable (other than current version)?
There was a problem hiding this comment.
Probably not, that's just normally not how we use FODs. They're used sparingly only when needed, because they disable part of the sandbox (mainly being able to reach the network).
There was a problem hiding this comment.
This will break if the build is not reproducible or does not yield the exact same output on all platforms.
While this is very unlikely, it's also very cumbersome to break and fix two hashes.
Also, ofborg will not touch files with multiple hashes iirc.
The change has no benefits at all while introducing possible issues.
There was a problem hiding this comment.
While we're at it, does this really need a full C build environment?
Edit: #103997 (comment)
Description of changes
#103997 (comment)
Changed
$out/share/fonts/ubuntuto$out/share/fonts/truetypeas it seems more common for TrueType fonts.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes