Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brscan4-etc-files: rename name to pname&version #197616

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

AndrewKvalheim
Copy link
Contributor

Description of changes

Decompose name into pname and version, re #103997.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nixpkgs-review rev brscan4-etc-files/pname-version.
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member

teto commented Oct 25, 2022

it s a valid patch :) anything else you wanted to do ? any ulterior motivation ?

@AndrewKvalheim
Copy link
Contributor Author

Having a consistent name structure simplifies allowlisting via allowUnfreePredicate.

@teto teto merged commit 545b74f into NixOS:master Oct 25, 2022
@AndrewKvalheim AndrewKvalheim deleted the brscan4-etc-files/pname-version branch November 19, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants