Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

__cleanAttrs: Clean packages that don't expose all internals #217243

Closed
wants to merge 31 commits into from
Closed

__cleanAttrs: Clean packages that don't expose all internals #217243

wants to merge 31 commits into from

Commits on Mar 14, 2023

  1. make-derivation.nix: Inline the call to derivation

    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    ef06fe8 View commit details
    Browse the repository at this point in the history

  2. lib.extendDerivation: Allow derivationStrict-style simple outputs

    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    db2571b View commit details
    Browse the repository at this point in the history

  3. make-derivation.nix: Remove intermediate derivation output wrappers

    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    3cbfa15 View commit details
    Browse the repository at this point in the history

  4. mkDerivation: Add __cleanAttrs ? false 

    This removes unnecessary implementation details from the package
attrset.
    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    59db5a5 View commit details
    Browse the repository at this point in the history

  5. mkDerivation: Do not expose passthru input attribute when __cleanAttrs

    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    89ff705 View commit details
    Browse the repository at this point in the history

  6. mkDerivation: Remove inputDerivation from __cleanAttrs packages

    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    9b45ecd View commit details
    Browse the repository at this point in the history

  7. mkDerivation: Add name and version to __cleanAttrs packages

    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    b9e7258 View commit details
    Browse the repository at this point in the history

  8. lib.inspectMkDerivationArgs: init, alternative to .drvAttrs for __cle… 

    …anArgs packages
    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    7a0bba8 View commit details
    Browse the repository at this point in the history

  9. pkgs.inputDerivation: Add pkg.inputDerivation alternative for __clean… 

    …Attrs packages
    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    3abc47f View commit details
    Browse the repository at this point in the history

  10. mkDerivation: Add outputs to __cleanAttrs packages

    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    416741d View commit details
    Browse the repository at this point in the history

  11. lib.hydraJob: Accept __cleanAttrs packages

    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    dc32ea5 View commit details
    Browse the repository at this point in the history

  12. hello: Expose src

    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    cd0de0e View commit details
    Browse the repository at this point in the history

  13. mkDerivation: Keep legacy name semantics 

    This avoids a mass-rebuild as many expressions currently use the
name+version pair instead of just a name.

The old meaning of name is based on the abused "name part" of store
paths, but there is no real reason for the attrset to use this odd
definition of name, except perhaps strong backward compatibility.
    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    d02174b View commit details
    Browse the repository at this point in the history

  14. make-derivation.nix: Remove a //

    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    2377feb View commit details
    Browse the repository at this point in the history

  15. make-derivation.nix: Remove a let

    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    fac41dd View commit details
    Browse the repository at this point in the history

  16. cutomisation.nix: Remove a //

    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    b7477b9 View commit details
    Browse the repository at this point in the history

  17. lib/customisation.nix: Refactor: convert if to or 

    Should be faster.
    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    bc10d59 View commit details
    Browse the repository at this point in the history

  18. make-derivation.nix: Inline genAttrs 

    Hoping to squeeze some performance out of this.
    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    2db600e View commit details
    Browse the repository at this point in the history

  19. make-derivation.nix: Save another // 

    Hoping to squeeze some performance out of this.
    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    7458ee0 View commit details
    Browse the repository at this point in the history

  20. hello: Simplify

    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    b2c0a99 View commit details
    Browse the repository at this point in the history

  21. salve-mundi: init 

    A very fancy wrapped GNU hello, showcasing various Nixpkgs features.
    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    36582b0 View commit details
    Browse the repository at this point in the history

  22. Revert "pkgs.inputDerivation: Add pkg.inputDerivation alternative for… 

    … __cleanAttrs packages"

Do not add this until we've decided what inputDerivation is
and how it fits in with cleanAttrs and the possible devShell
attribute
 - NixOS#206728

This reverts commit 99e1be309a70bfb8476b1892b8d102065860b2be.
    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    2295009 View commit details
    Browse the repository at this point in the history

  23. make-derivation.nix: Use formal for __cleanAttrs

    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    165a2de View commit details
    Browse the repository at this point in the history

  24. make-derivation.nix: Do expose internals when __cleanAttrs 

    Realistically, we'll want easier access than having to call a
function to extract these bits. Having to go through a function
means that the CLI becomes almost useless for troubleshooting,
and the same for tab completion in the repl.
    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    ce39083 View commit details
    Browse the repository at this point in the history

  25. Revert "lib.inspectMkDerivationArgs: init, alternative to .drvAttrs f… 

    …or __cleanArgs packages"

This was too unergonomic to be the only method for retrieving
these. By introducing the `internals` attribute for this purpose
instead, we restore easy access without setting any wrong
expectations regarding the stability of the contents.

This reverts commit 01eea717c474d25b1636f9ee93c9f7bf95907fc6.
    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    c24b772 View commit details
    Browse the repository at this point in the history

  26. salve-mundi.nix: Explain what the file is for

    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    c09aa93 View commit details
    Browse the repository at this point in the history

  27. doc/stdenv: Document __cleanAttrs

    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    dbb8745 View commit details
    Browse the repository at this point in the history

  28. doc/stdenv: Document __structuredAttrs

    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    b38a364 View commit details
    Browse the repository at this point in the history

  29. pkgs.tests.stdenv: Test __cleanAttrs

    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    854693c View commit details
    Browse the repository at this point in the history

  30. doc/rl-2305: Add __cleanAttrs

    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    a4655ce View commit details
    Browse the repository at this point in the history

  31. mkDerivation: Add __cleanAttrs = "warn"; 

    The implementation with dynamic attributes is a little weird, but
it performs better by avoiding some attrset copying and sorting, `//`.
    @roberth
    roberth committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    56a4141 View commit details
    Browse the repository at this point in the history