Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/types: allow changing the name of name #218812

Closed
wants to merge 1 commit into from

Commits on Feb 28, 2023

  1. lib/types: allow changing the name of name

    Adds a new `nameArgument` argument to `submoduleWith` that allows
    changing which argument the "name" (last item of `loc`, i.e. attribute
    name or option name this submodule appears under) is bound to.
    
    This avoids conflicts when `moduleType` is used inside a submodule,
    where `name` would be set to both the outer submodule's name and the
    inner one's. If the outer submodule type sets `nameArgument` to
    something different, `moduleType` will continue using `name`, avoiding
    the conflict.
    
    Ideally, there should probably be a way to change the inner `name` too
    to remove all ambiguity.
    ncfavier committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    13383f1 View commit details
    Browse the repository at this point in the history