Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetchMavenArtifact: deprecate phases & use pname+version #219707

Conversation

Stunkymonkey
Copy link
Contributor

Description of changes

#28910 & #103997

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda removed their request for review March 5, 2023 16:52
@dotlambda
Copy link
Member

I'm not actually familiar with fetchMavenArtifact, only modified it once to unbreak a package.

@Stunkymonkey Stunkymonkey force-pushed the fetchmavenartifact-deprecate-phases branch from 1a16102 to 6931020 Compare March 19, 2023 20:53
@Stunkymonkey Stunkymonkey force-pushed the fetchmavenartifact-deprecate-phases branch from 6931020 to 0f57b4b Compare March 26, 2023 16:45
@Stunkymonkey
Copy link
Contributor Author

Result of nixpkgs-review pr 219707 run on x86_64-linux 1

7 packages built:
  • liquibase
  • liquibase_redshift_extension
  • opentsdb
  • postgresql_jdbc
  • redshift_jdbc
  • sqlite-jdbc
  • squirrel-sql

@SuperSandro2000 SuperSandro2000 merged commit 2341c80 into NixOS:master Apr 8, 2023
@Stunkymonkey Stunkymonkey deleted the fetchmavenartifact-deprecate-phases branch November 22, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants