Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helix: 22.11 -> 23.03 #224397

Merged
merged 1 commit into from
Apr 3, 2023
Merged

helix: 22.11 -> 23.03 #224397

merged 1 commit into from
Apr 3, 2023

Conversation

leona-ya
Copy link
Member

@leona-ya leona-ya commented Apr 2, 2023

Description of changes

https://github.com/helix-editor/helix/blob/master/CHANGELOG.md#2303-2023-03-31

Superseeds #224062. We must use cargo lock for now, as upstream uses a git checkout of tree-sitter (via patch.crates-io)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@happysalada
Copy link
Contributor

@GrahamcOfBorg eval

@mweinelt
Copy link
Member

mweinelt commented Apr 2, 2023

Except buildins.readFile does not seem to want to read from ${src}/Cargo.lock. That's probably IFD, because src is a Fixed-Output Derivation (FOD).

@leona-ya
Copy link
Member Author

leona-ya commented Apr 3, 2023

Sorry @mweinelt. That was a product of me way to sleepy to do nix. I fixed up the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants