r2modman: init at 3.1.42

[aidalgol]

Description of changes

Add r2modman, an unofficial Thunderstore mod manager.

Builds from source, superseding PR #201708.

Closes #143659

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[huantianad]

Is there a good way to add the steam libraries so it can properly launch modded steam games?

[aidalgol]

Is there a good way to add the steam libraries so it can properly launch modded steam games?

I think you would need to run it inside the Steam FHS environment. I think letting the user opt to launch r2modman via steam-run is the best option.

(I've just been using this to install mods, and then launch the game from Steam.)

[lilyinstarlight]

I left a bunch of review comments, but this looks pretty good! I do wonder if it would benefit from organizing it without mkYarnPackage like how the teams-for-linux derivation does now (which is also an electron app that uses yarn)

[aidalgol]

I do wonder if it would benefit from organizing it without mkYarnPackage like how the teams-for-linux derivation does now (which is also an electron app that uses yarn)

That package does look a bit tidier. I will attempt to redo this package following that pattern, and for heroic as well if that works out.

[lilyinstarlight]

That package does look a bit tidier. I will attempt to redo this package following that pattern, and for heroic as well if that works out.

Hopefully we can get back to #210814 soon and have a modern builder instead of mixing and matching yarn2nix-moretea and fetchYarnDeps. I have a few open PRs for fixing up fetchYarnDeps before that, though, and we are currently trying to iron out npm stuff first

[aidalgol]

I have redone the package using stdenv.mkDerivation and fetchYarnDeps. I could not figure out how, or if it's even possible to make quasar run electron-builder offline, so we run quasar build --mode electron --skip-pkg and then copy node_modules into the output directory, instead of getting an .asar archive.

[huantianad]

Looks good to me, only thing remaining is launching steam games from the app. For general use I do launch via steam itself, not r2modman, but it would be helpful for user-friendliness. I can't think of a better way than maybe adding an option to derivation to use steam-run, even though that still feels awkward.

[aidalgol]

I think we should address supporting steam-run as a separate task. I also think that we should try to work with upstream to add support for customising the launch command.

[huantianad]

Sounds good, I like the idea of having an option to set a launch wrapper, kinda like how Prism Launcher does it.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/973

[SuperSandro2000]

Suggested change

	(cd public/icons
	for img in *png; do
	dimensions=''${img#favicon-}
	dimensions=''${dimensions%.png}
	mkdir -p $out/share/icons/hicolor/$dimensions/apps
	cp $img $out/share/icons/hicolor/$dimensions/apps/${pname}.png
	done)
	cd public/icons
	for img in *png; do
	dimensions=''${img#favicon-}
	dimensions=''${dimensions%.png}
	mkdir -p $out/share/icons/hicolor/$dimensions/apps
	cp $img $out/share/icons/hicolor/$dimensions/apps/${pname}.png
	done
	cd ../..

[aidalgol]

I much prefer cd in a subshell in shell scripts, so I would like to keep this bit as it is if that's OK.

[aidalgol]

Fixed.

[aidalgol]

@huantianad Do you want to be put down as a maintainer on this?

[huantianad]

Yeah sure, I'm down to help maintain.