code-server: 4.12.0 -> 4.13.0 #233493
Closed
code-server: 4.12.0 -> 4.13.0 #233493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drupol
force-pushed
the
code-servers/bump-may-2023
branch
from
7b233c5
to
48b9939
Compare
drupol
force-pushed
the
code-servers/bump-may-2023
branch
2 times, most recently
from
7f86bd1
to
1005d5a
Compare
henkery
approved these changes
May 23, 2023
|
I don't think it's good, it's not building |
henkery
reviewed
May 23, 2023
| @@ -1,12 +1,12 @@ | |||
| { lib, stdenv, fetchFromGitHub, buildGoModule, makeWrapper | |||
| , cacert, moreutils, jq, git, rsync, pkg-config, yarn, python3 | |||
| , esbuild, nodejs_16, node-gyp, libsecret, xorg, ripgrep | |||
| , esbuild, nodejs_18, node-gyp, libsecret, xorg, ripgrep | |||
There was a problem hiding this comment.
why did you change to nodejs 18, code-server officially still only supports 16
https://github.com/coder/code-server/blob/2109d1cf6abdf17e620a926239d9e96a07face4d/.github/workflows/release.yaml#LL38C13-L38C13
There was a problem hiding this comment.
nodejs_16 has been deprecated, so I'm just checking if this is working with NodeJS 18. I already made the change in openvscode-server at #232887
drupol
force-pushed
the
code-servers/bump-may-2023
branch
from
1005d5a
to
7dcacb0
Compare
|
@GrahamcOfBorg build code-server |
|
I guess I can close this PR now, it just doesn't work with NodeJS 18. |
|
made an issue at code-server to see if they can look into migrating first |
|
Work is continued in #234289 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)