-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http-parser: fix copying outputs for static build #254516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should target staging
since it rebuilds a lot of packages.
Patch itself LGTM.
changed base, thx for the info 👍 @FliegendeWurst |
Since 4056c43 a Make not Gyp build system has been in use.
Co-Authored-By: John Ericson <John.Ericson@Obsidian.Systems>
7607111
to
33f464b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I coincidentally did this locally --- I combined with my version to fix conflicts but still give you credit
eval lib tests failure is unrelated. |
Successfully created backport PR for |
Git push to origin failed for staging-23.05 with exitcode 1 |
Successfully created backport PR for |
Git push to origin failed for staging-23.11 with exitcode 1 |
Description of changes
Fixes derivation for http-parser in a static env to
install
the static archive to$out/lib
, based on the following issue and non-upstreamed nix solution.Currently,
pkgsStatic.http-parser
only results in a shared library in$out/lib
:After this change, we only have the static archive file:
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)