firefox: sha{256, 512} → hash #255518
Closed
firefox: sha{256, 512} → hash #255518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for `sha512`, refactor to easily add hash functions in the future.
mkg20001
reviewed
Oct 27, 2023
| @@ -43,6 +43,7 @@ writeScript "update-${attrPath}" '' | |||
| gpgv --keyring="$GNUPGHOME"/pubring.kbx "$HOME"/shasums.asc "$HOME"/shasums | |||
|
|
|||
| hash=$(grep '\.source\.tar\.xz$' "$HOME"/shasums | grep '^[^ ]*' -o) | |||
| sriHash=$(nix-hash --type sha512 --to-sri "$hash") | |||
|
|
|||
There was a problem hiding this comment.
sriHash is not used, maybe you forgot to update the update-source-version expr
|
I'm opposed to changing these hashes from the upstream provided ones to SRI. That just makes them harder to compare for just about anyone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
firefox.updateScriptfirefox/*.nixThe maintainer script is from #255512, I only included it in the history so as to document how the automatic rewrites were performed.
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage