Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tests: add failing test for dnsmasq+resolved #259644

Closed
wants to merge 1 commit into from

Conversation

Majiir
Copy link
Contributor

@Majiir Majiir commented Oct 7, 2023

Description of changes

When both dnsmasq and systemd-resolved are enabled, dnsmasq fails to start because resolved is already listening on port 53. This config allows the test to pass:

{
  services.dnsmasq.settings.bind-interfaces = true;
}

The intent of this test is to prepare for the transition to networkd where systemd-resolved will be enabled by default. See #202488 for that broader effort.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

When both dnsmasq and systemd-resolved are enabled, dnsmasq fails to
start because resolved is already listening on port 53. This config
allows the test to pass:

    {
      services.dnsmasq.settings.bind-interfaces = true;
    }

The intent of this test is to prepare for the transition to networkd
where systemd-resolved will be enabled by default.
@Majiir Majiir marked this pull request as ready for review October 7, 2023 22:24
@Majiir Majiir mentioned this pull request Oct 7, 2023
40 tasks
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@fpletz
Copy link
Member

fpletz commented Jul 4, 2024

I don't think it makes sense to add a failing test. At some point we could integrate a succeeding test in #264967.

@fpletz fpletz closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants