nixos/nix-serve: fix module compatibility with unflaked Nix #269280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flokli
reviewed
Nov 22, 2023
The option `extra-allowed-users` was introduced in Nix 2.4, and fails config validation on Nix 2.3.
tazjin
force-pushed
the
nix-serve-unflaked
branch
from
821cf61
to
b2f67d3
Compare
|
Successfully ran |
1 task
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option
extra-allowed-userswas introduced in Nix 2.4, and fails config validation on Nix 2.3.Relates to NixOS/nix#9412
Breakage discovered in https://cl.tvl.fyi/c/depot/+/10083, commit that introduced the bug was 44cf480