Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netbox 3.7.1 #282929

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Netbox 3.7.1 #282929

merged 4 commits into from
Jan 22, 2024

Conversation

minijackson
Copy link
Member

@minijackson minijackson commented Jan 22, 2024

Description of changes

  • add netbox_3_7 at 3.7.1
  • make it the default netbox package
  • make it the default for NixOS if stateVersion >= 24.05
  • make the "netbox-upgrade" NixOS test test the upgrade from 3.6 to 3.7
  • remove netbox_3_5
  • mark netbox_3_6 as EOL

cc @RaitoBezarius

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Or another way to see it:

netbox_3_7: init at 3.7.1

Make NetBox 3.7 the default version if stateVersion >= 24.05,
switch upgrade test to test upgrade from 3.6 to 3.7,
remove clearcache command for >=3.7.0,
make reindex command mandatory
@infinisil
Copy link
Member

You can ignore the pkgs/by-name check failure, this is not a problem of this PR, the check itself needs to be adjusted. Merging this PR won't be a problem for pkgs/by-name.

@lukegb
Copy link
Contributor

lukegb commented Jan 22, 2024

In your description you write

add netbox_3_4 at 3.7.1

Did you mean netbox_3_7?

@minijackson
Copy link
Member Author

@lukegb yes that's a typo. Fixed it, thanks!

@RaitoBezarius
Copy link
Member

Result of nixpkgs-review pr 282929 run on x86_64-linux 1

1 test built:
  • nixosTests.netbox_3_7

@RaitoBezarius
Copy link
Member

Result of nixpkgs-review pr 282929 run on x86_64-linux 1

1 package marked as broken and skipped:
  • netbox_3_6
2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
1 package built:
  • netbox (netbox_3_7)

@RaitoBezarius
Copy link
Member

I tested also the upgrade, seems to work fine, but I don't have permissions to deploy my non-trivial production Netbox, so I cannot test there. I think we can move on.

@RaitoBezarius RaitoBezarius merged commit 32a6e22 into NixOS:master Jan 22, 2024
29 of 30 checks passed
@infinisil
Copy link
Member

You can ignore the pkgs/by-name check failure, this is not a problem of this PR, the check itself needs to be adjusted. Merging this PR won't be a problem for pkgs/by-name.

Will be fixed with #285089

@minijackson minijackson deleted the netbox-3.7.1 branch March 24, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants