-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libcamera-qcam: init #284964
libcamera-qcam: init #284964
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall diff LGTM, maybe we should just ship the Qt5 build for now until upstream catches up though?
Quoting the patch:
I'd rather not introduce another qt5 dependency into nixpkgs ;-) |
That's not really the case, the KDE people maintain a Qt5 patchset that we track, and it'll be around for a while. I don't really see any issues with Qt5 stuff yet. |
647adc8
to
7190be6
Compare
Alright, I updated this PR and removed the qt6 patch from the history, PTAL. I left a pointer in the commit message, in case someone is wondering, even though I'd hope by then upstream switched to qt6 too. |
libcamera provides a more helpful debugging gui, which however needs qt, so is undesirable in the default case (which is why it was disabled initially). Introduce a withQcam boolean flag, which will enable building it with qcam, and expose it as a toplevel libcamera-qcam attribute. This helped debugging the new ipu6 softisp camera stack. The Qt 6 support patch is already circulating on the upstream mailing list, however it doesn't apply cleanly. As discussed in NixOS#284964, we opted to not ship that patch, but rather use qt5 for now, as KDE seems to maintain a Qt5 patchset that we track.
The CI check complains about a new attribute introduced that's not using the by-name pattern, even though it's using the same .nix file. It seems using callPackage ../by-name/… from toplevel for the alternative toplevel attribute seems to be others do this, so using the same pattern here.
7190be6
to
d6ee968
Compare
libcamera provides a more helpful debugging gui, which however needs qt, so is undesirable in the default case (which is why it was disabled initially).
Introduce a withQcam boolean flag, which will enable building it with qcam, and expose it as a toplevel libcamera-qcam attribute.
This helped debugging the new ipu6 softisp camera stack.
The Qt 6 support patch is already circulating on the upstream mailing list, however it doesn't apply cleanly.
Use the version from
https://copr-dist-git.fedorainfracloud.org/cgit/jwrdegoede/ipu6-softisp/libcamera.git/tree/0001-apps-qcam-Port-to-Qt-6.patch?h=f39 which has been rebased to apply.
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.