Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aliza: init at 1.9.7 #285657

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

aliza: init at 1.9.7 #285657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ac24a2e
aliza: init at 1.9.7
luxzeitlos Feb 2, 2024
fa99373
aliza: can't have it in by-name
luxzeitlos Feb 4, 2024
d616da9
Update pkgs/applications/science/medicine/aliza/default.nix
luxzeitlos Feb 5, 2024
8ac146b
Apply suggestions from code review
luxzeitlos Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions pkgs/applications/science/medicine/aliza/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
{ lib
, stdenv
, fetchFromGitHub
, wrapQtAppsHook
, itk
, cmake
, qtbase
}:

stdenv.mkDerivation (finalAttrs: {
pname = "aliza";
version = "1.9.7";

src = fetchFromGitHub {
owner = "AlizaMedicalImaging";
repo = "AlizaMS";
rev = "v${finalAttrs.version}";
hash = "sha256-bambl3NP42KEwh6NPb8jhQlGqaUCSt6QuzUmmBnEAQw=";
};

nativeBuildInputs = [
wrapQtAppsHook
];

buildInputs = [
itk
cmake
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually it goes on nativeBuildInputs.

qtbase
];

luxzeitlos marked this conversation as resolved.
Show resolved Hide resolved
strictDeps = true;

cmakeFlags = [
"-DCMAKE_BUILD_TYPE:STRING=Release"
"-DALIZA_QT_VERSION:STRING=5"
"-DITK_DIR:STRING=${itk}"
"-DMDCM_USE_SYSTEM_ZLIB:BOOL=ON"
Comment on lines +34 to +37
Copy link
Member

@AndersonTorres AndersonTorres Feb 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"-DCMAKE_BUILD_TYPE:STRING=Release"
"-DALIZA_QT_VERSION:STRING=5"
"-DITK_DIR:STRING=${itk}"
"-DMDCM_USE_SYSTEM_ZLIB:BOOL=ON"
(lib.cmakeFeature "CMAKE_BUILD_TYPE" "Release")
(lib.cmakeFeature "ALIZA_QT_VERSION" "5")
(lib.cmakeOptionType "filepath" "ITK_DIR" itk)
(lib.cmakeBool "MDCM_USE_SYSTEM_ZLIB" true)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure (lib.cmakeBool "-MDCM_USE_SYSTEM_ZLIB" true) is correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... why not?

];

installPhase = ''
runHook preInstall
install -Dm555 ./bin/* -t $out/bin
runHook postInstall
'';

meta = with lib; {
description = "A DICOM Viewer";
homepage = "https://www.aliza-dicom-viewer.com/";
license = licenses.gpl3Only;
maintainers = with maintainers; [ lux ];
platforms = platforms.linux;
mainProgram = "alizams";
};
}
2 changes: 2 additions & 0 deletions pkgs/top-level/all-packages.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39301,6 +39301,8 @@ with pkgs;

### SCIENCE/MEDICINE

aliza = libsForQt5.callPackage ../applications/science/medicine/aliza { };

dcmtk = callPackage ../applications/science/medicine/dcmtk { };

xmedcon = callPackage ../applications/science/medicine/xmedcon { };
Expand Down
Loading