postgresqlPackages.pgvecto-rs: init at 0.2.1 #287632
Conversation
Co-authored-by: rina <k@rina.fyi>
esclear
force-pushed
the
add-pgvecto-rs
branch
from
7fde3c2
to
c20f20e
Compare
|
Commit message |
esclear
force-pushed
the
add-pgvecto-rs
branch
from
c20f20e
to
35691c7
Compare
|
@thoughtpolice @marsam |
esclear
force-pushed
the
add-pgvecto-rs
branch
from
35691c7
to
7b78d34
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3539 |
|
@ofborg build postgresqlPackages.pgvectors |
|
Fails to build on aarch64-linux, see ofborg log |
esclear
force-pushed
the
add-pgvecto-rs
branch
2 times, most recently
from
e8e8d5f
to
6e94cf0
Compare
|
Hi, sorry for the delay. It looks great, thank you! I'll take a proper look tonight |
|
Thanks for checking, Sandro. This appears to be a known issue with bindgen < 0.69. pgvecto.rs 0.2.0 depends on pgrx 0.11.2 and thus does not include the fix yet, but will include it in the next release. |
|
pgvecto.rs v0.2.1 was released today, I updated this PR to reflect that. |
Co-authored-by: Diogo Correia <me@diogotc.com>
|
Hi, sorry for the delay. @GrahamcOfBorg test pgvecto-rs |
marsam
changed the title
| }; | ||
|
|
||
| nativeBuildInputs = [ | ||
| rustPlatform.bindgenHook |
There was a problem hiding this comment.
Clang version isn't locked here like the other PR does.
| meta = with lib; { | ||
| description = "Scalable Vector database plugin for Postgres, written in Rust, specifically designed for LLM"; | ||
| homepage = "https://github.com/tensorchord/pgvecto.rs"; | ||
| maintainers = with maintainers; [ esclear ]; |
There was a problem hiding this comment.
@diogotcorreia would you like to be added as a maintainer here?
| description = "Scalable Vector database plugin for Postgres, written in Rust, specifically designed for LLM"; | ||
| homepage = "https://github.com/tensorchord/pgvecto.rs"; | ||
| maintainers = with maintainers; [ esclear ]; | ||
| platforms = [ "x86_64-linux" ]; |
There was a problem hiding this comment.
From the other PR:
| platforms = [ "x86_64-linux" ]; | |
| broken = (stdenv.isLinux && stdenv.isAarch64) || stdenv.isDarwin; |
There was a problem hiding this comment.
Doesn't that imply, that it is working / supported on all linux platforms, except for aarch64?
I.e. support on ["armv5tel-linux" "armv6l-linux" "armv7a-linux" "armv7l-linux" "i686-linux" "loongarch64-linux" "m68k-linux" "microblaze-linux" "microblazeel-linux" "mips-linux" "mips64-linux" "mips64el-linux" "mipsel-linux" "powerpc64-linux" "powerpc64le-linux" "riscv32-linux" "riscv64-linux" "s390-linux" "s390x-linux"]?
This does not seem to match the platforms that pgvecto.rs supports.
There was a problem hiding this comment.
For platforms, we usually list all the platforms that are not explicitly unsupported or cannot be supported for this package. For example, macOS-specific packages will only have platforms.darwin.
A generic rust package however should theoretically compile on any platform where its dependencies can be compiled on.
The only platforms that are important to list here are the 4 platforms which Nixpkgs properly supports. If those are all supported in theory, just say platforms.all (default). If you know a package is specific for all UNIX platforms or only Linux from the get-go (i.e. util-linux), obviously mark it as such. Those are kinda rare though; even traditionally UNIX-only libraries such as GTK or Xorg theoretically function on Windows or macOS too these days.
If there is nothing preventing a build from working in theory but it doesn't compile or breaks at runtime for some reason, you mark it as broken as I suggested here.
Does pgvecto.rs have any explicit platform constraints? I was not able to find any in their documentation.
|
Closing this in favor of #281192. |
Description of changes
From the pgvecto.rs repository:
Big thanks to @katrinafyi, who helped me getting the clang build going.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.