nv-codec-headers: adopt and refactor

[AndersonTorres]

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[AndersonTorres]

@infinisil it looks like a bug to me! Can you verify?

I am using an external file to parameterize the nv-codec-headers-${version}.

[infinisil]

Not a bug I'm afraid! To CI, the nv-codec-headers-9 looks just like a new package defined with pkgs.callPackage.

Since pkgs/by-name can't yet handle package sets, I recommend refactoring this to:

  inherit (callPackages ../development/libraries/nv-codec-headers { })
    nv-codec-headers-9 nv-codec-headers-10;

or if you want to also expose the set of versions:

  nv-codec-headers-versions = callPackages ../development/libraries/nv-codec-headers { };
  inherit (nv-codec-headers-versions)
    nv-codec-headers-9 nv-codec-headers-10;

See also #285922 (comment) or #287081 for some discussion on this.

[AndersonTorres]

callPackages in plural? Oh jeez

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3486