vivaldi: support gtk4 #291033
vivaldi: support gtk4 #291033
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
| @@ -4,7 +4,7 @@ | |||
| , freetype, fontconfig, libXft, libXrender, libxcb, expat | |||
| , libuuid | |||
| , libxml2 | |||
| , glib, gtk3, pango, gdk-pixbuf, cairo, atk, at-spi2-atk, at-spi2-core | |||
| , glib, gtk3, gtk4, pango, gdk-pixbuf, cairo, atk, at-spi2-atk, at-spi2-core | |||
There was a problem hiding this comment.
A similar issue exists with qt: currently vivadi is built against qt5 and doesn't work with qt6: #286522 (comment)
I am somewhat hesitant making vivaldy unconditionally depend on all of gtk3, gtk4, qt5, and qt6.
Maybe a better approach is to make both of these parameters?
, gtk ? gtk3
, qt ? qt5
There was a problem hiding this comment.
We don't depend on gtk2 directly and we probably can't depend on qt5 and qt6 at the same time anyway.
There was a problem hiding this comment.
can't depend on qt5 and qt6 at the same time anyway.
Yup, that's why I suggest making this parameter which can be either qt5 or qt6, but only one of the two.
There was a problem hiding this comment.
Yeah, this does seem to work for me locally:
Don't understand enough about nixpkgs to judge whether this is a good idea or not :)
Description of changes
Vivaldi cannot works on gtk4 even if give it to
--gtk-version=4because it cannot findgtk4.Since some input method such as
fcitx5requiretext-input-v3, we need to run browsers on gtk4.comparable:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.