nixos/hyprland: Add systemd.setPath.enable option to include system and user bin directory in PATH

[JohnRTitor]

Description of changes

This PR adds systemd.setPath.enable option to hyprland module which sets systemd default environment path to include the current system's bin, profile bin and current user's bin.
This is needed in Hyprland only setups, where opening links in applications like VS code do not work without explicitly importing PATH using systemctl.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[JohnRTitor]

@wozeparrot @fufexan Hyprland package maintainers

[fufexan]

LGTM.

One thing though, mdDoc is now the default and can be omitted. Can you perhaps also remove any occurrence of it in a separate commit?

[JohnRTitor]

Done. Also added possible binary dirs such as the user packages bin, profiles/default/bin...

@fufexan please check.

[fufexan]

The commits should start with nixos/hyprland: ... and possibly have more concise titles. Further explanations can go into the commit message.

[fufexan]

Commit names still aren't fixed.

[JohnRTitor]

How do I amend previously created commits? git commit --amend only amends the latest commit.

[fufexan]

You can do git rebase --interactive HEAD~4 to select the latest 4 commits (your commits), and change the pick keyword to reword. Then git will prompt you to edit each of the commits' messages.

[JohnRTitor]

Thanks for the tip :) I have updated the commit titles. Please check.

[fufexan]

The last two commits can be squashed into one. Using the same rebase mechanism, switch the last commit from pick to squash.

[JohnRTitor]

Done. Thanks :)

[fufexan]

LGTM

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3716

[JohnRTitor]

@wegank I just rebased it :) no new changes

[JohnRTitor]

@Mic92 could you please review it? Fufexan approved this change but still need a commiter to merge.

[Schweber]

Since this was merged i get the following:

$ kitty sh hx                                                                                                                               
[104 15:36:23.528696] [glfw error 65544]: process_desktop_settings: failed with error: [org.freedesktop.DBus.Error.UnknownMethod] No such interface “org.freedesktop.portal.Settings” on object at path /org/freedesktop/portal/desktop

It worked fine before. Might this be caused by this PR or is this unrelated?

[JohnRTitor]

It worked fine before. Might this be caused by this PR or is this unrelated?

Working for me. Weird.
I might have misunderstood the issue.
Please explain what is the expected behaviour.
I don't see any output like that in stdout/err if I run that command.
Kitty launches for a second and closes instantly.

Note: you can disable this by setting the following in your configuration.nix:

programs.hyprland.systemd.setPath.enable = false;

[Schweber]

Kitty launches for a second and closes instantly.

Exactly. Before, the window stayed open as intended. When i first run kitty and then run hx in the kitty window, it stays open as before.

foot sh hx shows the same behaviour but without the error output. So i guess the problem is not caused by kitty.

Note: you can disable this by setting the following in your configuration.nix:

programs.hyprland.systemd.setPath.enable = false;

Sorry, i didn't think of that. I disabled it and the behaviour is still there. So i guess my problem is unrelated to this PR, sorry.