Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnucap: deprecate phases #299011

Merged
merged 1 commit into from
Mar 25, 2024
Merged

gnucap: deprecate phases #299011

merged 1 commit into from
Mar 25, 2024

Conversation

Stunkymonkey
Copy link
Contributor

Description of changes

part of #28910

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Stunkymonkey
Copy link
Contributor Author

Result of nixpkgs-review pr 299011 run on x86_64-linux 1

1 package built:
  • gnucap-full

1 similar comment
@Mic92
Copy link
Member

Mic92 commented Mar 25, 2024

Result of nixpkgs-review pr 299011 run on x86_64-linux 1

1 package built:
  • gnucap-full

@Mic92 Mic92 merged commit a23d5d8 into NixOS:master Mar 25, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboof raboof Awaiting requested review from raboof

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stunkymonkey @Mic92