pgadmin4: add darwin build #302812
Merged
pgadmin4: add darwin build #302812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: darwin
|
note: tests fail for |
|
@ofborg build pgadmin4 pgadmin4.passthru.tests |
fixexs NixOS#281214 Signed-off-by: Florian Brandes <florian.brandes@posteo.de>
|
Result of 4 packages built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This fixes the build for
aarch64-darwinandx86_64-darwin. (Which never really worked before..)fixexs #281214
Please note: There is an issue on MacOS with
keyring: It will ask everytime twice for the admin password when started. Then it will print an error on the logs and one can enter the pgadmin Master password. This can be skipped by saying "don't allow" when promped by MacOS and directly entering the master password.Issue on pgadmin: pgadmin-org/pgadmin4#7076
Issue upstream: jaraco/keyring#619
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.