Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pwalarmd: init at 0.1.0 #315703

Merged
merged 1 commit into from
May 31, 2024
Merged

pwalarmd: init at 0.1.0 #315703

merged 1 commit into from
May 31, 2024

Conversation

amyipdev
Copy link
Contributor

Description of changes

This patch adds pwalarmd, a daemon which provides alarm clock services with custom notification support and live command-line configuration editing (achieved through pwalarmctl, which will be requested for addition separately).

This patch does not add a service file, as pwalarmd is meant to be run in user mode. Home-Manager support will be added separately later for running pwalarmd under systemd/with declarative configuration.

Homepage: https://github.com/amyipdev/pwalarmd

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin N/A
    • aarch64-darwin N/A
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • [] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage N/A
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking N/A
    • (Module updates) Added a release notes entry if the change is significant N/A
    • (Module addition) Added a release notes entry if adding a new NixOS module N/A
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@amyipdev
Copy link
Contributor Author

Will fix and repush

@amyipdev
Copy link
Contributor Author

Assuming OfBorg tests pass, PR is ready for consideration.

@heisfer
Copy link
Contributor

heisfer commented May 30, 2024

Result of nixpkgs-review pr 315703 run on x86_64-linux 1

1 package built:
  • pwalarmd

@heisfer
Copy link
Contributor

heisfer commented May 30, 2024

Well, after reading more about https://github.com/NixOS/nixpkgs/tree/master/pkgs#meta-attributes I think meta.mainProgram should be also present since it doesn't include pwalarmctl.

Tested basic config provided by GitHub repo and worked just fine.

This patch adds pwalarmd, a daemon which provides alarm clock
services with custom notification support and live command-line
configuration editing (achieved through pwalarmctl, which will
be requested for addition separately).

This patch does not add a service file, as pwalarmd is meant to
be run in user mode. Home-Manager support will be added separately
later for running pwalarmd under systemd/with declarative
configuration.

Signed-off-by: Amy Parker <amy@amyip.net>
@amyipdev
Copy link
Contributor Author

@heisfer added

@Aleksanaa Aleksanaa merged commit eb3a1d7 into NixOS:master May 31, 2024
31 checks passed
@amyipdev amyipdev mentioned this pull request May 31, 2024
13 tasks
wegank pushed a commit to amyipdev/nixpkgs that referenced this pull request Jun 12, 2024
This patch adds pwalarmctl, a controller and status tool for the
pwalarmd daemon that was merged in NixOS#315703.

Signed-off-by: Amy Parker <amy@amyip.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants