-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misskey: init at 2024.5.0 & nixos/misskey: init module #319348
Conversation
9bbc6bf
to
b20f817
Compare
623949a
to
ae7a23f
Compare
be1547d
to
73ca462
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me appart from minor comment
Before merging please squash your changes so that there is one that adds yourself as maintainer, one that adds the package, one that adds the module |
Thanks a lot @feathecutie! |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-summer-of-nix-program-updates/46053/4 |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-319348-to-release-24.05 origin/release-24.05
cd .worktree/backport-319348-to-release-24.05
git switch --create backport-319348-to-release-24.05
git cherry-pick -x 70cf12a6d7a7eb86a0ba05f2ad703cfe76e19c28 564a6e61a0e0c6df9eda3baf78071ed59f722248 0c9cb0041ba1835fe630d015be292cfc75922761 |
Description of changes
This adds the Misskey blogging platform by providing a package and accompanying NixOS module.
Source code: https://github.com/misskey-dev/misskey
Homepage: https://misskey-hub.net/en/
This PR is largely inspired by #296697.
TODO / Nice to have:
settings.{db.pass,redis.pass,meilisearch.apiKey}
.settings
field.settings
to be in a state where Misskey doesn't crash at runtime, e.g. when certain options arenull
.settings.url
starts withhttps://
orhttp://
. This seems quite error prone, so a seperate toggle for SSL in nginx might make sense. Luckily, Caddy handles this automatically based on the URL type.Feedback is welcome for any of the remaining (or even completed) TODOs.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.