Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onlyoffice-bin_latest: 8.0.0 -> 8.1.0 #322861

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

leon-erd
Copy link
Contributor

Description of changes

I dont know why the automatic update did not trigger. Is there a problem with the update script?
Changelog: https://github.com/ONLYOFFICE/DesktopEditors/blob/master/CHANGELOG.md#810
Onlyoffice was split into onlyoffice-bin and onlyoffice-bin_latest because versions after 7.2 were broken on wlroots (see #285888). However, first reports indicate that wlroots support is fixed in 8.1.0 (see ONLYOFFICE/DesktopEditors#1208 (comment)). So maybe there is no need anymore for the 7.2 version?

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@nh2 @GTrunSec @fin444

Add a 👍 reaction to pull requests you find important.

@SuperSandro2000
Copy link
Member

So maybe there is no need anymore for the 7.2 version?

If that is true, we should drop the old version.

@fin444
Copy link
Contributor

fin444 commented Jun 29, 2024

Too lazy to set up a WM on my NixOS install, but I live-booted Manjaro Sway and it works great there.

However, 8.0.1 also works in that setup - possibly fixed from wlroots end?

@leon-erd
Copy link
Contributor Author

On my hyprland machine 8.1.0 and 8.0.1 also both work. But hyprland is kinda detached from wlroots now

@fin444
Copy link
Contributor

fin444 commented Jun 29, 2024

Hyprland implemented their own patches for this issue, so it's not suitable to test

@SuperSandro2000 SuperSandro2000 merged commit 52a7fb0 into NixOS:master Jul 2, 2024
27 checks passed
@leon-erd leon-erd deleted the update_onlyoffice branch July 3, 2024 10:27
@leon-erd leon-erd mentioned this pull request Jul 3, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants